Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows-curses dependency for Windows #1134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

biozz
Copy link
Contributor

@biozz biozz commented Aug 6, 2020

Closes #1100.

Disclaimer: I am using macOS and have difficulties setting up Windows environment to test this feature, so I would like to have some feedback from Windows users out there, pinging @ltalirz.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 63.875% when pulling 363e667 on biozz:f/1100_add_windows_curses into 2bedab0 on circus-tent:master.

@ltalirz
Copy link
Contributor

ltalirz commented Aug 6, 2020

@biozz Thanks for this - I don't use windows regularly either, and even if I did I think the best solution is to include a basic windows test in the CI.

In order to achieve this, I would suggest to:

  • move the CI from travis to github actions
  • add a test run on a windows runner, at least for one python version (also put one in for Macos, while we're at it)

I've had a look at the travis config of circus and it looks rather minimal.
I'll have a quick go at a PR for 20 minutes - would you be happy to continue in case it turns out to take more effort?

@biozz
Copy link
Contributor Author

biozz commented Aug 6, 2020

@ltalirz yes, sure thing. I was also checking out travis docs and it has multi-os support including windows.

Personally I don't have any preference on the ci as long as it works and not too complicated to setup. Tagging @k4nar for an opinion.

@ltalirz
Copy link
Contributor

ltalirz commented Aug 6, 2020

I was also checking out travis docs and it has multi-os support including windows.

I see, wasn't even aware of that.
We've been using Github actions since a couple of months and have been pretty happy with it, especially in terms of speed.

20 minutes was a bit too optimistic but looks like I'm done. Will make a PR.

@k4nar
Copy link
Contributor

k4nar commented Aug 10, 2020

I tried to add a Windows CI via AppVeyor a few years ago, without any success. If you manage to do it that would be awesome!

@ltalirz
Copy link
Contributor

ltalirz commented Aug 10, 2020

If you manage to do it that would be awesome!

It's already done :-) However, the tests are still skipped on windows, i.e. it remains to be seen whether there are still tricks to be played. @biozz is kindly working on it

@biozz
Copy link
Contributor Author

biozz commented Aug 14, 2020

I am still trying to setup windows environment: virtualbox with windows server 2019 and things break where you don't expect. So that's why it takes quite a lot of time.

UPD: I couldn't get it to work, so for the time being this will have to wait for someone with windows experience to complete...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curses not available on windows
4 participants